Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689063002: Cleanup: Replace base::ASCIIToWide with base::ASCIIToUTF16. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, sadrul, benjhayden+dwatch_chromium.org, tfarina, jam, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Replace base::ASCIIToWide with base::ASCIIToUTF16. BUG=23581 Committed: https://crrev.com/e5c64d9a2cb63bce791faeed3691db80ecc127b5 Cr-Commit-Position: refs/heads/master@{#303142}

Patch Set 1 #

Patch Set 2 : lint #

Total comments: 2

Patch Set 3 : fix temporary #

Patch Set 4 : rebase #

Patch Set 5 : rebase, fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M apps/launcher.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/crash/app/breakpad_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/save_package_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_geturl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_device_listener_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/keygen_handler_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_sspi_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/url_security_manager_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tools/imagediff/image_diff.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Lei Zhang
6 years, 1 month ago (2014-10-31 19:59:58 UTC) #2
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/689063002/diff/20001/net/proxy/proxy_resolver_winhttp.cc File net/proxy/proxy_resolver_winhttp.cc (right): https://codereview.chromium.org/689063002/diff/20001/net/proxy/proxy_resolver_winhttp.cc#newcode57 net/proxy/proxy_resolver_winhttp.cc:57: options.lpszAutoConfigUrl = base::ASCIIToUTF16(pac_url_.spec()).c_str(); looks buggy, the c_str() is that ...
6 years, 1 month ago (2014-11-03 17:33:27 UTC) #3
Lei Zhang
https://codereview.chromium.org/689063002/diff/20001/net/proxy/proxy_resolver_winhttp.cc File net/proxy/proxy_resolver_winhttp.cc (right): https://codereview.chromium.org/689063002/diff/20001/net/proxy/proxy_resolver_winhttp.cc#newcode57 net/proxy/proxy_resolver_winhttp.cc:57: options.lpszAutoConfigUrl = base::ASCIIToUTF16(pac_url_.spec()).c_str(); On 2014/11/03 17:33:27, cpu wrote: > ...
6 years, 1 month ago (2014-11-03 23:02:10 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-11-04 21:24:55 UTC) #5
cpu_(ooo_6.6-7.5)
please do check again in case I missed another unnamed temporary.
6 years, 1 month ago (2014-11-04 21:25:30 UTC) #6
Lei Zhang
On 2014/11/04 21:25:30, cpu wrote: > please do check again in case I missed another ...
6 years, 1 month ago (2014-11-04 21:57:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689063002/60001
6 years, 1 month ago (2014-11-04 21:58:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/82556)
6 years, 1 month ago (2014-11-04 22:44:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689063002/80001
6 years, 1 month ago (2014-11-06 23:10:12 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-07 01:19:33 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 01:20:34 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/e5c64d9a2cb63bce791faeed3691db80ecc127b5
Cr-Commit-Position: refs/heads/master@{#303142}

Powered by Google App Engine
This is Rietveld 408576698