Cleanup: Replace base::ASCIIToWide with base::ASCIIToUTF16.

net/proxy/proxy_resolver_winhttp.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_resolver_winhttp.h"
 
 #include <windows.h>
 #include <winhttp.h>
 
 #include "base/metrics/histogram.h"
@@ skipping 36 matching lines @@
 
   // If we have been given an empty PAC url, then use auto-detection.
   //
   // NOTE: We just use DNS-based auto-detection here like Firefox.  We do this
   // to avoid WinHTTP's auto-detection code, which while more featureful (it
   // supports DHCP based auto-detection) also appears to have issues.
   //
   WINHTTP_AUTOPROXY_OPTIONS options = {0};
   options.fAutoLogonIfChallenged = FALSE;
   options.dwFlags = WINHTTP_AUTOPROXY_CONFIG_URL;
-  std::wstring pac_url_wide = base::ASCIIToWide(pac_url_.spec());
-  options.lpszAutoConfigUrl = pac_url_wide.c_str();
+  options.lpszAutoConfigUrl = base::ASCIIToUTF16(pac_url_.spec()).c_str();

[cpu_(ooo_6.6-7.5), 2014/11/03 17:33:27]

looks buggy, the c_str() is that of a temporary string.

[Lei Zhang, 2014/11/03 23:02:10]

Whoops, undone.

 
   WINHTTP_PROXY_INFO info = {0};
   DCHECK(session_handle_);
 
   // Per http://msdn.microsoft.com/en-us/library/aa383153(VS.85).aspx, it is
   // necessary to first try resolving with fAutoLogonIfChallenged set to false.
   // Otherwise, we fail over to trying it with a value of true.  This way we
   // get good performance in the case where WinHTTP uses an out-of-process
   // resolver.  This is important for Vista and Win2k3.
   BOOL ok = WinHttpGetProxyForUrl(session_handle_,
-                                  base::ASCIIToWide(query_url.spec()).c_str(),
+                                  base::ASCIIToUTF16(query_url.spec()).c_str(),
                                   &options, &info);
   if (!ok) {
     if (ERROR_WINHTTP_LOGIN_FAILURE == GetLastError()) {
       options.fAutoLogonIfChallenged = TRUE;
       ok = WinHttpGetProxyForUrl(
-          session_handle_, base::ASCIIToWide(query_url.spec()).c_str(),
+          session_handle_, base::ASCIIToUTF16(query_url.spec()).c_str(),
           &options, &info);
     }
     if (!ok) {
       DWORD error = GetLastError();
       // If we got here because of RPC timeout during out of process PAC
       // resolution, no further requests on this session are going to work.
       if (ERROR_WINHTTP_TIMEOUT == error ||
           ERROR_WINHTTP_AUTO_PROXY_SERVICE_ERROR == error) {
         CloseWinHttpSession();
       }
@@ skipping 79 matching lines @@
 }
 
 void ProxyResolverWinHttp::CloseWinHttpSession() {
   if (session_handle_) {
     WinHttpCloseHandle(session_handle_);
     session_handle_ = NULL;
   }
 }
 
 }  // namespace net