Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 688973004: Plumbing for variations headers from synthetic field trials. (Closed)

Created:
6 years, 1 month ago by Alexei Svitkine (slow)
Modified:
6 years, 1 month ago
Reviewers:
jwd, sky
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Plumbing for variations headers from synthetic field trials. BUG=428055 Committed: https://crrev.com/e0dbdbe3aa7dce4dda9e9acb20325d8476003fa8 Cr-Commit-Position: refs/heads/master@{#302331}

Patch Set 1 : #

Patch Set 2 : Expose another hashed API in variations_associated_data.h #

Patch Set 3 : Expose another hashed API in variations_associated_data.h #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -24 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/metrics_service.h View 5 chunks +24 lines, -0 lines 0 comments Download
M components/metrics/metrics_service.cc View 4 chunks +19 lines, -0 lines 0 comments Download
M components/variations.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/net/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/net/variations_http_header_provider.h View 4 chunks +12 lines, -2 lines 0 comments Download
M components/variations/net/variations_http_header_provider.cc View 3 chunks +28 lines, -19 lines 2 comments Download
M components/variations/variations_associated_data.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M components/variations/variations_associated_data.cc View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Alexei Svitkine (slow)
6 years, 1 month ago (2014-10-31 14:42:15 UTC) #5
jwd
https://codereview.chromium.org/688973004/diff/100001/components/variations/net/variations_http_header_provider.cc File components/variations/net/variations_http_header_provider.cc (right): https://codereview.chromium.org/688973004/diff/100001/components/variations/net/variations_http_header_provider.cc#newcode147 components/variations/net/variations_http_header_provider.cc:147: GetGoogleVariationIDFromHashes(GOOGLE_WEB_PROPERTIES, group.id); Are there no plans to support triggering ...
6 years, 1 month ago (2014-10-31 18:50:26 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/688973004/diff/100001/components/variations/net/variations_http_header_provider.cc File components/variations/net/variations_http_header_provider.cc (right): https://codereview.chromium.org/688973004/diff/100001/components/variations/net/variations_http_header_provider.cc#newcode147 components/variations/net/variations_http_header_provider.cc:147: GetGoogleVariationIDFromHashes(GOOGLE_WEB_PROPERTIES, group.id); On 2014/10/31 18:50:26, Jesse Doherty wrote: > ...
6 years, 1 month ago (2014-10-31 18:51:06 UTC) #7
jwd
lgtm
6 years, 1 month ago (2014-10-31 18:56:03 UTC) #8
Alexei Svitkine (slow)
+sky for chrome/browser owners review - thanks!
6 years, 1 month ago (2014-10-31 19:02:52 UTC) #10
sky
LGTM
6 years, 1 month ago (2014-10-31 19:05:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688973004/100001
6 years, 1 month ago (2014-10-31 19:15:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:100001)
6 years, 1 month ago (2014-10-31 22:00:06 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:00:46 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e0dbdbe3aa7dce4dda9e9acb20325d8476003fa8
Cr-Commit-Position: refs/heads/master@{#302331}

Powered by Google App Engine
This is Rietveld 408576698