Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: components/variations/net/variations_http_header_provider.h

Issue 688973004: Plumbing for variations headers from synthetic field trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Expose another hashed API in variations_associated_data.h Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/net/variations_http_header_provider.h
diff --git a/components/variations/net/variations_http_header_provider.h b/components/variations/net/variations_http_header_provider.h
index a0e30461c54ef69dfd16df2361cdf1dbcecf5e9c..0a511cc17af128a95e40b6ec31078493c0b399aa 100644
--- a/components/variations/net/variations_http_header_provider.h
+++ b/components/variations/net/variations_http_header_provider.h
@@ -7,11 +7,13 @@
#include <set>
#include <string>
+#include <vector>
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
#include "base/metrics/field_trial.h"
#include "base/synchronization/lock.h"
+#include "components/metrics/metrics_service.h"
#include "components/variations/variations_associated_data.h"
namespace content {
@@ -31,7 +33,8 @@ namespace variations {
// A helper class for maintaining client experiments and metrics state
// transmitted in custom HTTP request headers.
// This class is a thread-safe singleton.
-class VariationsHttpHeaderProvider : base::FieldTrialList::Observer {
+class VariationsHttpHeaderProvider : public base::FieldTrialList::Observer,
+ public metrics::SyntheticTrialObserver {
public:
static VariationsHttpHeaderProvider* GetInstance();
@@ -66,12 +69,16 @@ class VariationsHttpHeaderProvider : base::FieldTrialList::Observer {
VariationsHttpHeaderProvider();
~VariationsHttpHeaderProvider() override;
- // base::FieldTrialList::Observer implementation.
+ // base::FieldTrialList::Observer:
// This will add the variation ID associated with |trial_name| and
// |group_name| to the variation ID cache.
void OnFieldTrialGroupFinalized(const std::string& trial_name,
const std::string& group_name) override;
+ // metrics::SyntheticTrialObserver:
+ void OnSyntheticTrialsChanged(
+ const std::vector<metrics::SyntheticTrialGroup>& groups) override;
+
// Prepares the variation IDs cache with initial values if not already done.
// This method also registers the caller with the FieldTrialList to receive
// new variation IDs.
@@ -102,6 +109,9 @@ class VariationsHttpHeaderProvider : base::FieldTrialList::Observer {
std::set<VariationID> default_variation_ids_set_;
std::set<VariationID> default_trigger_id_set_;
+ // Variations ids from synthetic field trials.
+ std::set<VariationID> synthetic_variation_ids_set_;
+
std::string variation_ids_header_;
DISALLOW_COPY_AND_ASSIGN(VariationsHttpHeaderProvider);

Powered by Google App Engine
This is Rietveld 408576698