Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68893032: Mojo: generated pointer 'getters' should return const pointers. (Closed)

Created:
7 years, 1 month ago by darin (slow to review)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: generated pointer 'getters' should return const pointers. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
7 years, 1 month ago (2013-11-16 19:11:45 UTC) #1
abarth-chromium
Do you have any sort of testing for this code? LGTM
7 years, 1 month ago (2013-11-16 20:36:33 UTC) #2
darin (slow to review)
No, not of the generator code. That's on the TODO list. -Darin On Sat, Nov ...
7 years, 1 month ago (2013-11-16 22:14:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/68893032/1
7 years, 1 month ago (2013-11-17 15:51:07 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 08:09:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 235655

Powered by Google App Engine
This is Rietveld 408576698