mojo/public/bindings/generators/mojom_cpp_generator.py - Issue 68893032: Mojo: generated pointer 'getters' should return const pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/generators/mojom_cpp_generator.py

Issue 68893032: Mojo: generated pointer 'getters' should return const pointers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/bindings/generators/mojom_cpp_generator.py b/mojo/public/bindings/generators/mojom_cpp_generator.py

index f807f0f11bfcfcd7f6be02c82e58202c090c34bc..a34a5b5df76641579544b90c05098e0b4a9dbbed 100644

--- a/mojo/public/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/bindings/generators/mojom_cpp_generator.py

@@ -84,7 +84,7 @@ class CPPGenerator(object):

getter_template = \

Template(" $TYPE $FIELD() const { return ${FIELD}_; }")

ptr_getter_template = \

- Template(" $TYPE $FIELD() const { return ${FIELD}_.ptr; }")

+ Template(" const $TYPE $FIELD() const { return ${FIELD}_.ptr; }")

pad_template = Template(" uint8_t _pad${COUNT}_[$PAD];")

templates = {}

HEADER_SIZE = 8

« no previous file with comments | « no previous file | no next file » | no next file with comments »