components/app_modal_dialogs/app_modal_dialog.h - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal_dialogs/app_modal_dialog.h

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view.cc ('K') | « components/app_modal_dialogs/BUILD.gn ('k') | components/app_modal_dialogs/app_modal_dialog.cc » ('j') | components/app_modal_dialogs/javascript_dialog_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/app_modal_dialogs/app_modal_dialog.h

diff --git a/components/app_modal_dialogs/app_modal_dialog.h b/components/app_modal_dialogs/app_modal_dialog.h

index 12d7f5cd6f5d0039db1e7a9126ed9b87fb7fd2e2..2a9cf896a03f6b59b118f57b5e28f13ac52fd91a 100644

--- a/components/app_modal_dialogs/app_modal_dialog.h

+++ b/components/app_modal_dialogs/app_modal_dialog.h

@@ -11,12 +11,13 @@

#include "base/strings/string16.h"

#include "build/build_config.h"

-class NativeAppModalDialog;

namespace content {

class WebContents;

}

+namespace app_modal_dialogs {

+class NativeAppModalDialog;

msw 2014/11/15 00:51:56 nit: blank line before

// A controller+model base class for modal dialogs.

class AppModalDialog {

public:

@@ -102,4 +103,6 @@ class AppModalDialogObserver {

DISALLOW_COPY_AND_ASSIGN(AppModalDialogObserver);

};

+} // namespace app_modal_dialogs

#endif // COMPONENTS_APP_MODAL_DIALOGS_APP_MODAL_DIALOG_H_