Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/app_modal_dialogs/BUILD.gn

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/frame/browser_view.cc ('K') | « components/app_modal_dialogs.gypi ('k') | components/app_modal_dialogs/app_modal_dialog.h » ('j') | components/app_modal_dialogs/app_modal_dialog.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/app_modal_dialogs/BUILD.gn
diff --git a/components/app_modal_dialogs/BUILD.gn b/components/app_modal_dialogs/BUILD.gn
index ef2f9329bad78e272a927301889c25a0ca5a26b1..339d9db11407c384dec63571f5098d17c2e21cc8 100644
--- a/components/app_modal_dialogs/BUILD.gn
+++ b/components/app_modal_dialogs/BUILD.gn
@@ -16,8 +16,6 @@ static_library("app_modal_dialogs") {
"javascript_dialog_extension_client.h",
"javascript_dialog_manager.cc",
"javascript_dialog_manager.h",
- "javascript_dialog_manager_impl.cc",
- "javascript_dialog_manager_impl.h",
"javascript_native_dialog_factory.h",
"native_app_modal_dialog.h"
]
« chrome/browser/ui/views/frame/browser_view.cc ('K') | « components/app_modal_dialogs.gypi ('k') | components/app_modal_dialogs/app_modal_dialog.h » ('j') | components/app_modal_dialogs/app_modal_dialog.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698