Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h
diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h
index b3001805eb0b48de88ce713bbccc603a89c1fe68..98c9b09421233b851f0d4ef591464a6bfaafa071 100644
--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h
+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h
@@ -18,9 +18,11 @@ class NSAlert;
class JavaScriptAppModalDialogHelper;
#endif
-class JavaScriptAppModalDialogCocoa : public NativeAppModalDialog {
+class JavaScriptAppModalDialogCocoa
+ : public app_modal_dialogs::NativeAppModalDialog {
public:
- explicit JavaScriptAppModalDialogCocoa(JavaScriptAppModalDialog* dialog);
+ explicit JavaScriptAppModalDialogCocoa(
+ app_modal_dialogs::JavaScriptAppModalDialog* dialog);
virtual ~JavaScriptAppModalDialogCocoa();
// Overridden from NativeAppModalDialog:
@@ -31,13 +33,15 @@ class JavaScriptAppModalDialogCocoa : public NativeAppModalDialog {
void AcceptAppModalDialog() override;
void CancelAppModalDialog() override;
- JavaScriptAppModalDialog* dialog() const { return dialog_.get(); }
+ app_modal_dialogs::JavaScriptAppModalDialog* dialog() const {
+ return dialog_.get();
+ }
private:
// Returns the NSAlert associated with the modal dialog.
NSAlert* GetAlert() const;
- scoped_ptr<JavaScriptAppModalDialog> dialog_;
+ scoped_ptr<app_modal_dialogs::JavaScriptAppModalDialog> dialog_;
// Created in the constructor and destroyed in the destructor.
base::scoped_nsobject<JavaScriptAppModalDialogHelper> helper_;

Powered by Google App Engine
This is Rietveld 408576698