Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3530)

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
index 214e1380953072a90a4ec16484f24f2dffa7357a..359230d4586fb61dcbc6925c21d5fb03f060231d 100644
--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
@@ -219,7 +219,7 @@ enum AlertAction {
// JavaScriptAppModalDialogCocoa, public:
JavaScriptAppModalDialogCocoa::JavaScriptAppModalDialogCocoa(
- JavaScriptAppModalDialog* dialog)
+ app_modal_dialogs::JavaScriptAppModalDialog* dialog)
: dialog_(dialog),
helper_(NULL) {
// Determine the names of the dialog buttons based on the flags. "Default"
@@ -440,14 +440,14 @@ void JavaScriptAppModalDialogCocoa::CancelAppModalDialog() {
namespace {
class ChromeJavaScritpNativeDialogCocoaFactory
- : public JavaScriptNativeDialogFactory {
+ : public app_modal_dialogs::JavaScriptNativeDialogFactory {
public:
ChromeJavaScritpNativeDialogCocoaFactory() {}
~ChromeJavaScritpNativeDialogCocoaFactory() override {}
private:
- NativeAppModalDialog* CreateNativeJavaScriptDialog(
- JavaScriptAppModalDialog* dialog,
+ app_modal_dialogs::NativeAppModalDialog* CreateNativeJavaScriptDialog(
+ app_modal_dialogs::JavaScriptAppModalDialog* dialog,
gfx::NativeWindow parent_window) override {
return new JavaScriptAppModalDialogCocoa(dialog);
}
@@ -458,6 +458,7 @@ class ChromeJavaScritpNativeDialogCocoaFactory
} // namespace
void InstallChromeJavaScriptNativeDialogFactory() {
- SetJavaScriptNativeDialogFactory(
- make_scoped_ptr(new ChromeJavaScritpNativeDialogCocoaFactory));
+ app_modal_dialogs::JavaScriptDialogManager::GetInstance()->
+ SetNativeDialogFactory(
+ make_scoped_ptr(new ChromeJavaScritpNativeDialogCocoaFactory));
}

Powered by Google App Engine
This is Rietveld 408576698