chrome/browser/lifetime/browser_close_manager_browsertest.cc - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/browser_close_manager_browsertest.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/ui/android/javascript_app_modal_dialog_android.h » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/browser_close_manager_browsertest.cc

diff --git a/chrome/browser/lifetime/browser_close_manager_browsertest.cc b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

index c0768e7ebf12c85464baea1afd93277b466df7b7..8dec0a61416d8be05b4fe91aaeb378e13b62c341 100644

--- a/chrome/browser/lifetime/browser_close_manager_browsertest.cc

+++ b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

@@ -49,11 +49,12 @@

namespace {

-NativeAppModalDialog* GetNextDialog() {

- AppModalDialog* dialog = ui_test_utils::WaitForAppModalDialog();

+app_modal_dialogs::NativeAppModalDialog* GetNextDialog() {

+ app_modal_dialogs::AppModalDialog* dialog =

+ ui_test_utils::WaitForAppModalDialog();

EXPECT_TRUE(dialog->IsJavaScriptModalDialog());

- JavaScriptAppModalDialog* js_dialog =

- static_cast<JavaScriptAppModalDialog*>(dialog);

+ app_modal_dialogs::JavaScriptAppModalDialog* js_dialog =

+ static_cast<app_modal_dialogs::JavaScriptAppModalDialog*>(dialog);

CHECK(js_dialog->native_dialog());

return js_dialog->native_dialog();

}