chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extension_host_delegate.cc ('k') | chrome/browser/lifetime/browser_close_manager_browsertest.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index 0c69af2a7b7e13a1f5de508ddbb53222ae5f5b19..31823acbdc9e63c1f8c37b3541c5165e6d376885 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -216,7 +216,8 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, WaitForDialog) {

ASSERT_TRUE(extension);

// The test extension opens a dialog on installation.

- AppModalDialog* dialog = ui_test_utils::WaitForAppModalDialog();

+ app_modal_dialogs::AppModalDialog* dialog =

+ ui_test_utils::WaitForAppModalDialog();

ASSERT_TRUE(dialog);

// With the dialog open the background page is still alive.