chrome/browser/extensions/chrome_extension_host_delegate.cc - Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_host_delegate.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: namespace Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/athena_javascript_native_dialog_factory.cc ('K') | « chrome/browser/extensions/alert_apitest.cc ('k') | chrome/browser/extensions/lazy_background_page_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_host_delegate.cc

diff --git a/chrome/browser/extensions/chrome_extension_host_delegate.cc b/chrome/browser/extensions/chrome_extension_host_delegate.cc

index e318d64ff74ee7995c43d2cfedd32eb927e0ec00..4b71712bfc95fd9c4746aa03d0bfdea62bef18bf 100644

--- a/chrome/browser/extensions/chrome_extension_host_delegate.cc

+++ b/chrome/browser/extensions/chrome_extension_host_delegate.cc

@@ -35,7 +35,7 @@ void ChromeExtensionHostDelegate::OnRenderViewCreatedForBackgroundPage(

content::JavaScriptDialogManager*

ChromeExtensionHostDelegate::GetJavaScriptDialogManager() {

- return GetJavaScriptDialogManagerInstance();

+ return app_modal_dialogs::JavaScriptDialogManager::GetInstance();

}

void ChromeExtensionHostDelegate::CreateTab(content::WebContents* web_contents,