Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: chrome/browser/extensions/alert_apitest.cc

Issue 688853005: Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: namespace Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/alert_apitest.cc
diff --git a/chrome/browser/extensions/alert_apitest.cc b/chrome/browser/extensions/alert_apitest.cc
index 2b5787408ac8de7c534cc6383b304003a9c9333e..bb6b13fe0fae6a5946af59d89d034914516a7c2f 100644
--- a/chrome/browser/extensions/alert_apitest.cc
+++ b/chrome/browser/extensions/alert_apitest.cc
@@ -24,7 +24,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, AlertBasic) {
host->host_contents()->GetMainFrame()->ExecuteJavaScript(
base::ASCIIToUTF16("alert('This should not crash.');"));
- AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();
+ app_modal_dialogs::AppModalDialog* alert =
+ ui_test_utils::WaitForAppModalDialog();
ASSERT_TRUE(alert);
alert->CloseModalDialog();
}

Powered by Google App Engine
This is Rietveld 408576698