Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 688803002: ServiceWorker: Remove unused startMode field from WebEmbeddedWorkerStartData [1/2] (Closed)

Created:
6 years, 1 month ago by nhiroki
Modified:
6 years, 1 month ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove unused startMode field from WebEmbeddedWorkerStartData [1/2] [1] Chromium-side: THIS PATCH [2] Blink-side: https://codereview.chromium.org/686353003 BUG=n/a TEST=compile Committed: https://crrev.com/1ac52cddda002cf4acd63c2bc1d43743e56b2b4f Cr-Commit-Position: refs/heads/master@{#302050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
Ptal, thanks!
6 years, 1 month ago (2014-10-30 06:48:19 UTC) #2
Kunihiko Sakamoto
lgtm
6 years, 1 month ago (2014-10-30 06:53:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688803002/1
6 years, 1 month ago (2014-10-30 07:03:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 07:44:52 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 07:45:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ac52cddda002cf4acd63c2bc1d43743e56b2b4f
Cr-Commit-Position: refs/heads/master@{#302050}

Powered by Google App Engine
This is Rietveld 408576698