Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 686353003: ServiceWorker: Remove unused startMode field from WebEmbeddedWorkerStartData [2/2] (Closed)

Created:
6 years, 1 month ago by nhiroki
Modified:
6 years, 1 month ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Remove unused startMode field from WebEmbeddedWorkerStartData [2/2] [1] Chromium-side: https://codereview.chromium.org/688803002/ [2] Blink-side: THIS PATCH BUG=n/a TEST=compile Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M public/web/WebEmbeddedWorkerStartData.h View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nhiroki
PTAL.
6 years, 1 month ago (2014-10-30 06:49:59 UTC) #2
Kunihiko Sakamoto
lgtm
6 years, 1 month ago (2014-10-30 06:54:01 UTC) #3
nhiroki
Kent-san, can you review this? Thanks!
6 years, 1 month ago (2014-10-30 08:41:39 UTC) #7
tkent
lgtm
6 years, 1 month ago (2014-10-31 01:34:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686353003/1
6 years, 1 month ago (2014-10-31 01:35:06 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 02:14:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184685

Powered by Google App Engine
This is Rietveld 408576698