Remove incorrect RenderTableCell FIXME

Remove incorrect RenderTableCell FIXME

We should not implement this change, since table cells would not update if we
later set their row/colspan to 1.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185183

[rtakacs, 2014-11-10 14:06:37]

rtakacs.u-szeged@partner.samsung.com changed reviewers:
+ jchaffraix@chromium.org

[rtakacs, 2014-11-10 14:09:40]

Let's assume we have a colspan = 1 and a rowspan = 5.
If we set rowspan back to 1, the (!m_hasColSpan && !m_hasRowSpan) condition is
true, so if we want a return in this case, the table cell won't update.

So the suspicion (in the FIXME comment) is wrong.

[Julien - ping for review, 2014-11-10 18:07:15]

On 2014/11/10 at 14:09:40, rtakacs.u-szeged wrote:
> Let's assume we have a colspan = 1 and a rowspan = 5.
> If we set rowspan back to 1, the (!m_hasColSpan && !m_hasRowSpan) condition is
true, so if we want a return in this case, the table cell won't update.
> 
> So the suspicion (in the FIXME comment) is wrong.

How about if you haven't changed colspan or rowspan? This function is called
regardless of whether you *actually* changed either of them AFAICT.

Regardless, lgtm.

[rtakacs, 2014-11-11 10:38:56]

On 2014/11/10 18:07:15, Julien Chaffraix - PST wrote:
> On 2014/11/10 at 14:09:40, rtakacs.u-szeged wrote:
> > Let's assume we have a colspan = 1 and a rowspan = 5.
> > If we set rowspan back to 1, the (!m_hasColSpan && !m_hasRowSpan) condition
is
> true, so if we want a return in this case, the table cell won't update.
> > 
> > So the suspicion (in the FIXME comment) is wrong.
> 
> How about if you haven't changed colspan or rowspan?
> This function is called regardless of whether you *actually* changed either of
them AFAICT.

The colSpanOrRowSpanChanged() (where the FIXME is) is called only if the node
has a renderer.
This could happen when you define a rowspan with a value, and later you would
like to modify the value by javascript.
So if you haven't changed colspan or rowspan then colSpanOrRowSpanChanged() is
not called.

> 
> Regardless, lgtm.

[rtakacs, 2014-11-11 20:21:59]

The CQ bit was checked by rtakacs.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-11-11 20:22:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688683004/1

[commit-bot: I haz the power, 2014-11-11 22:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 22:05:24]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35902)

[rtakacs, 2014-11-12 05:52:39]

The CQ bit was checked by rtakacs.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-11-12 05:52:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688683004/1

[commit-bot: I haz the power, 2014-11-12 06:42:14]

Committed patchset #1 (id:1) as 185183