Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/rendering/RenderTableCell.cpp

Issue 688683004: Remove incorrect RenderTableCell FIXME (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 m_hasRowSpan = node() && parseRowSpanFromDOM() != 1; 95 m_hasRowSpan = node() && parseRowSpanFromDOM() != 1;
96 } 96 }
97 97
98 void RenderTableCell::colSpanOrRowSpanChanged() 98 void RenderTableCell::colSpanOrRowSpanChanged()
99 { 99 {
100 ASSERT(node()); 100 ASSERT(node());
101 ASSERT(isHTMLTableCellElement(*node())); 101 ASSERT(isHTMLTableCellElement(*node()));
102 102
103 updateColAndRowSpanFlags(); 103 updateColAndRowSpanFlags();
104 104
105 // FIXME: I suspect that we could return early here if !m_hasColSpan && !m_h asRowSpan.
106
107 setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(); 105 setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
108 if (parent() && section()) 106 if (parent() && section())
109 section()->setNeedsCellRecalc(); 107 section()->setNeedsCellRecalc();
110 } 108 }
111 109
112 Length RenderTableCell::logicalWidthFromColumns(RenderTableCol* firstColForThisC ell, Length widthFromStyle) const 110 Length RenderTableCell::logicalWidthFromColumns(RenderTableCol* firstColForThisC ell, Length widthFromStyle) const
113 { 111 {
114 ASSERT(firstColForThisCell && firstColForThisCell == table()->colElement(col ())); 112 ASSERT(firstColForThisCell && firstColForThisCell == table()->colElement(col ()));
115 RenderTableCol* tableCol = firstColForThisCell; 113 RenderTableCol* tableCol = firstColForThisCell;
116 114
(...skipping 1146 matching lines...) Expand 10 before | Expand all | Expand 10 after
1263 1261
1264 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent) 1262 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent)
1265 { 1263 {
1266 RenderTableCell* newCell = RenderTableCell::createAnonymous(&parent->documen t()); 1264 RenderTableCell* newCell = RenderTableCell::createAnonymous(&parent->documen t());
1267 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL); 1265 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL);
1268 newCell->setStyle(newStyle.release()); 1266 newCell->setStyle(newStyle.release());
1269 return newCell; 1267 return newCell;
1270 } 1268 }
1271 1269
1272 } // namespace blink 1270 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698