Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 688663004: Fix mismatched parentheses that were revealed through /analyze warnings. (Closed)

Created:
6 years, 1 month ago by brucedawson
Modified:
6 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mismatched parentheses that were revealed through /analyze warnings. The incorrectly placed parentheses means that failure of the first function didn't stop the others from executing, and overall failure was evaluated incorrectly -- always succeeding I think. Warnings were: d:\src\chromium2\src\media\audio\win\core_audio_util_win.cc(361) : C6215: Cast between semantically different integer types: Boolean type to HRESULT. C6230: Implicit cast between semantically different integer types: using HRESULT in a Boolean context. BUG=427616 Committed: https://crrev.com/ef7aaab8ef5dbd2c0538eee5339ae2908717b779 Cr-Commit-Position: refs/heads/master@{#302340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/win/core_audio_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brucedawson
6 years, 1 month ago (2014-10-30 21:23:47 UTC) #2
DaleCurtis
Nice find, lgtm
6 years, 1 month ago (2014-10-30 22:00:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688663004/1
6 years, 1 month ago (2014-10-31 21:02:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 22:55:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ef7aaab8ef5dbd2c0538eee5339ae2908717b779 Cr-Commit-Position: refs/heads/master@{#302340}
6 years, 1 month ago (2014-10-31 22:56:06 UTC) #8
henrika (OOO until Aug 14)
6 years, 1 month ago (2014-11-03 08:53:28 UTC) #9
Message was sent while issue was closed.
Thanks! LGTM.

Powered by Google App Engine
This is Rietveld 408576698