Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 688493003: [Ozone] Fix multiple definition of GpuMemoryBufferFactory::Create() (Closed)

Created:
6 years, 1 month ago by dnicoara
Modified:
6 years, 1 month ago
Reviewers:
reveman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Fix multiple definition of GpuMemoryBufferFactory::Create() https://codereview.chromium.org/699643002 moved gpu_memory_buffer_factory_x11.cc to *_linux.cc. Since Ozone provides its own implementation there are multiple definitions of the same symbol. BUG=none NOTRY=true TBR=piman@chromium.org Committed: https://crrev.com/366b0f00aeb7cbe92a59690d17c18d55dc26014b Cr-Commit-Position: refs/heads/master@{#302551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/common/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dnicoara
6 years, 1 month ago (2014-11-04 01:49:25 UTC) #2
reveman
sorry, my bad. thanks for fixing this. lgtm.
6 years, 1 month ago (2014-11-04 02:01:42 UTC) #4
dnicoara
On 2014/11/04 02:01:42, reveman wrote: > sorry, my bad. thanks for fixing this. lgtm. No ...
6 years, 1 month ago (2014-11-04 02:17:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688493003/1
6 years, 1 month ago (2014-11-04 02:18:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 02:20:30 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 02:21:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/366b0f00aeb7cbe92a59690d17c18d55dc26014b
Cr-Commit-Position: refs/heads/master@{#302551}

Powered by Google App Engine
This is Rietveld 408576698