Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issue 699643002: ui: Remove GLImageGLX. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui: Remove GLImageGLX. This code is not being shipped and there are no plans that will change that. Remove it for now as it means less code to maintain and will allow some cleanup. It can be added back later if needed. BUG= R=piman@chromium.org Committed: https://crrev.com/fa4afa9c8737114462d305adfa1def3f000318dd Cr-Commit-Position: refs/heads/master@{#302470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -486 lines) Patch
M content/common/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
A + content/common/gpu/gpu_memory_buffer_factory_linux.cc View 3 chunks +4 lines, -29 lines 0 comments Download
D content/common/gpu/gpu_memory_buffer_factory_x11.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D content/common/gpu/gpu_memory_buffer_factory_x11_pixmap.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/common/gpu/gpu_memory_buffer_factory_x11_pixmap.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M content/content_common.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gl/gl_image_glx.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/gl/gl_image_glx.cc View 1 chunk +0 lines, -205 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
reveman
6 years, 1 month ago (2014-11-03 16:56:25 UTC) #1
piman
lgtm
6 years, 1 month ago (2014-11-03 19:12:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699643002/1
6 years, 1 month ago (2014-11-03 19:14:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699643002/1
6 years, 1 month ago (2014-11-03 19:19:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 19:56:48 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 19:57:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa4afa9c8737114462d305adfa1def3f000318dd
Cr-Commit-Position: refs/heads/master@{#302470}

Powered by Google App Engine
This is Rietveld 408576698