Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 68823004: [Translate] Apply language synonyms to the target language (Closed)

Created:
7 years, 1 month ago by Miguel Garcia
Modified:
7 years, 1 month ago
CC:
chromium-reviews, hajimehoshi
Visibility:
Public.

Description

[Translate] Apply language synonyms to the target language Expose ConvertLangCodeForTranslation and use it when converting the UX language for all platforms (the performance hit should be negligible and this way it is more legible than adding a #ifdef Android) Fix a few unrelated typos on comments while at it. BUG=311624 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M chrome/browser/translate/translate_language_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_prefs.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_prefs.cc View 2 chunks +18 lines, -20 lines 0 comments Download
M components/translate/common/translate_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Miguel Garcia
Some context (also in the bug). Hebrew's code in Android is detected as "he" while ...
7 years, 1 month ago (2013-11-11 17:08:25 UTC) #1
Takashi Toyoshima
LGTM. Also, thank you for some spelling fixes.
7 years, 1 month ago (2013-11-12 19:44:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/68823004/1
7 years, 1 month ago (2013-11-12 20:05:01 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=188653
7 years, 1 month ago (2013-11-12 21:11:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/68823004/1
7 years, 1 month ago (2013-11-12 21:28:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/68823004/1
7 years, 1 month ago (2013-11-12 23:54:25 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 01:55:14 UTC) #7
Message was sent while issue was closed.
Change committed as 234706

Powered by Google App Engine
This is Rietveld 408576698