Issue 688223002: Get rid of isWritingModeRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 688223002: Get rid of isWritingModeRoot. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
mojo-reviews_chromium.org, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Get rid of isWritingModeRoot. This function always returns false now that we don't have writing modes. TBR=esprehn@chromium.org Remove flipForWritingMode. It's a noop now that we don't have writing modes. Committed: https://chromium.googlesource.com/external/mojo/+/98686a4b7e6d7a4af9151845240fb97a417d694c

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -45 lines)			Patch
M	sky/engine/core/rendering/RenderBlock.cpp	View	1	6 chunks	+9 lines, -32 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.cpp	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderFlexibleBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

ojan

6 years, 1 month ago (2014-10-30 02:53:09 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
98686a4b7e6d7a4af9151845240fb97a417d694c (presubmit successful).