Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: sky/engine/core/rendering/RenderBox.h

Issue 688223002: Get rid of isWritingModeRoot. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: merge to ToT Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlockFlow.cpp ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 void removeFloatingOrPositionedChildFromBlockLists(); 502 void removeFloatingOrPositionedChildFromBlockLists();
503 503
504 RenderLayer* enclosingFloatPaintingLayer() const; 504 RenderLayer* enclosingFloatPaintingLayer() const;
505 505
506 virtual int firstLineBoxBaseline() const { return -1; } 506 virtual int firstLineBoxBaseline() const { return -1; }
507 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock. 507 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock.
508 508
509 bool shrinkToAvoidFloats() const; 509 bool shrinkToAvoidFloats() const;
510 virtual bool avoidsFloats() const; 510 virtual bool avoidsFloats() const;
511 511
512 bool isWritingModeRoot() const { return false; }
513
514 bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloati ngOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBox(); } 512 bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloati ngOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBox(); }
515 513
516 virtual LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositio nMode = PositionOnContainingLine) const override; 514 virtual LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositio nMode = PositionOnContainingLine) const override;
517 virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode , LinePositionMode = PositionOnContainingLine) const override; 515 virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode , LinePositionMode = PositionOnContainingLine) const override;
518 516
519 virtual LayoutUnit offsetLeft() const override; 517 virtual LayoutUnit offsetLeft() const override;
520 virtual LayoutUnit offsetTop() const override; 518 virtual LayoutUnit offsetTop() const override;
521 519
522 // These represent your location relative to your container as a physical of fset. 520 // These represent your location relative to your container as a physical of fset.
523 // In layout related methods you almost always want the logical location (e. g. x() and y()). 521 // In layout related methods you almost always want the logical location (e. g. x() and y()).
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 if (UNLIKELY(inlineBoxWrapper() != 0)) 755 if (UNLIKELY(inlineBoxWrapper() != 0))
758 deleteLineBoxWrapper(); 756 deleteLineBoxWrapper();
759 } 757 }
760 758
761 ensureRareData().m_inlineBoxWrapper = boxWrapper; 759 ensureRareData().m_inlineBoxWrapper = boxWrapper;
762 } 760 }
763 761
764 } // namespace blink 762 } // namespace blink
765 763
766 #endif // RenderBox_h 764 #endif // RenderBox_h
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBlockFlow.cpp ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698