Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 688173002: Refactor RendererAccessibiltiyComplete back into RendererAccessibility. (Closed)

Created:
6 years, 1 month ago by Sungmann Cho
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, nasko
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor RendererAccessibiltiyComplete back into RendererAccessibility. After landing of https://codereview.chromium.org/651593002, the inheritance relationship between RendererAccessibility and RendererAccessibiltiyComplete is not necessary anymore. So we can make them one class. BUG=417758 Committed: https://crrev.com/fef4b7c4c2d59f71059e0ca93a3aef3f009b7e5b Cr-Commit-Position: refs/heads/master@{#302197}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -628 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.h View 1 chunk +74 lines, -26 lines 1 comment Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 chunk +409 lines, -3 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 13 chunks +25 lines, -27 lines 0 comments Download
D content/renderer/accessibility/renderer_accessibility_complete.h View 1 chunk +0 lines, -109 lines 0 comments Download
D content/renderer/accessibility/renderer_accessibility_complete.cc View 1 chunk +0 lines, -454 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 1 month ago (2014-10-30 06:06:50 UTC) #2
dmazzoni
lgtm +nasko for OWNERS review of content/ https://codereview.chromium.org/688173002/diff/1/content/renderer/accessibility/renderer_accessibility.h File content/renderer/accessibility/renderer_accessibility.h (right): https://codereview.chromium.org/688173002/diff/1/content/renderer/accessibility/renderer_accessibility.h#newcode42 content/renderer/accessibility/renderer_accessibility.h:42: // This ...
6 years, 1 month ago (2014-10-30 15:15:49 UTC) #4
nasko
Rubberstamp LGTM, as dmazzoni@ knows this code and has reviewed it.
6 years, 1 month ago (2014-10-30 23:31:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688173002/1
6 years, 1 month ago (2014-10-30 23:36:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 00:25:19 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 00:25:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef4b7c4c2d59f71059e0ca93a3aef3f009b7e5b
Cr-Commit-Position: refs/heads/master@{#302197}

Powered by Google App Engine
This is Rietveld 408576698