Remove RendererAccessibilityFocusOnly.

Remove RendererAccessibilityFocusOnly.

After landing of https://codereview.chromium.org/600263002,
RendererAccessibilityFocusOnly class is no longer necessary.
So we can remove it and related codes.

BUG=417758
Committed: https://crrev.com/cbaf69539f099899555220b092ba3a501634bab3
Cr-Commit-Position: refs/heads/master@{#300482}

[Sungmann Cho, 2014-10-11 08:03:49]

sungmann.cho@navercorp.com changed reviewers:
+ dmazzoni@chromium.org

[Sungmann Cho, 2014-10-11 08:04:05]

Please take a look. Thanks!

[dmazzoni, 2014-10-13 07:25:15]

Thanks! We also need to get rid of some tests from
renderer_accessibility_browsertest.cc, and everything related to the
AccessibilityModeEditableTextOnly flag.

If you're interested in contributing this, would you also refactor
RendererAccessibiltiyComplete back into RendererAccessibility in a follow-up
change? There's no longer a need for a parent class and subclass.

[Sungmann Cho, 2014-10-14 03:43:49]

On 2014/10/13 07:25:15, dmazzoni wrote:
> Thanks! We also need to get rid of some tests from
> renderer_accessibility_browsertest.cc, and everything related to the
> AccessibilityModeEditableTextOnly flag.

I submitted new patch set. Please take a look.

> If you're interested in contributing this, would you also refactor
> RendererAccessibiltiyComplete back into RendererAccessibility in a follow-up
> change? There's no longer a need for a parent class and subclass.

Got It! :)

[Sungmann Cho, 2014-10-16 18:04:42]

ping...

[dmazzoni, 2014-10-17 20:03:53]

https://codereview.chromium.org/651593002/diff/130001/content/browser/accessi...
File content/browser/accessibility/accessibility_mode_helper_unittest.cc (left):

https://codereview.chromium.org/651593002/diff/130001/content/browser/accessi...
content/browser/accessibility/accessibility_mode_helper_unittest.cc:34:
AddAccessibilityModeTo(AccessibilityModeEditableTextOnly,
Rather than deleting this test, could you use AccessibilityModeTreeOnly in place
of AccessibilityModeEditableTextOnly?

https://codereview.chromium.org/651593002/diff/130001/content/renderer/access...
File content/renderer/accessibility/renderer_accessibility.h (right):

https://codereview.chromium.org/651593002/diff/130001/content/renderer/access...
content/renderer/accessibility/renderer_accessibility.h:19: enum
RendererAccessibilityType {
You should just delete this whole enum now, since there's only one possible
value.

https://codereview.chromium.org/651593002/diff/130001/content/renderer/render...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/651593002/diff/130001/content/renderer/render...
content/renderer/render_view_impl.cc:74: #include
"content/renderer/accessibility/renderer_accessibility.h"
None of these are needed in this file - please remove all three.

[Sungmann Cho, 2014-10-18 14:14:07]

https://codereview.chromium.org/651593002/diff/130001/content/browser/accessi...
File content/browser/accessibility/accessibility_mode_helper_unittest.cc (left):

https://codereview.chromium.org/651593002/diff/130001/content/browser/accessi...
content/browser/accessibility/accessibility_mode_helper_unittest.cc:34:
AddAccessibilityModeTo(AccessibilityModeEditableTextOnly,
On 2014/10/17 20:03:53, dmazzoni wrote:
> Rather than deleting this test, could you use AccessibilityModeTreeOnly in
place
> of AccessibilityModeEditableTextOnly?

Done.

https://codereview.chromium.org/651593002/diff/130001/content/renderer/access...
File content/renderer/accessibility/renderer_accessibility.h (right):

https://codereview.chromium.org/651593002/diff/130001/content/renderer/access...
content/renderer/accessibility/renderer_accessibility.h:19: enum
RendererAccessibilityType {
On 2014/10/17 20:03:53, dmazzoni wrote:
> You should just delete this whole enum now, since there's only one possible
> value.

I'm going to refactor RendererAccessibilityComplete back into
RendererAccessibility in a follow-up CL. So could I postpone this work to that
CL?

https://codereview.chromium.org/651593002/diff/130001/content/renderer/render...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/651593002/diff/130001/content/renderer/render...
content/renderer/render_view_impl.cc:74: #include
"content/renderer/accessibility/renderer_accessibility.h"
On 2014/10/17 20:03:53, dmazzoni wrote:
> None of these are needed in this file - please remove all three.

Done.

[dmazzoni, 2014-10-20 16:42:43]

lgtm

https://codereview.chromium.org/651593002/diff/130001/content/renderer/access...
File content/renderer/accessibility/renderer_accessibility.h (right):

https://codereview.chromium.org/651593002/diff/130001/content/renderer/access...
content/renderer/accessibility/renderer_accessibility.h:19: enum
RendererAccessibilityType {
On 2014/10/18 14:14:06, Sungmann Cho wrote:
> On 2014/10/17 20:03:53, dmazzoni wrote:
> > You should just delete this whole enum now, since there's only one possible
> > value.
> 
> I'm going to refactor RendererAccessibilityComplete back into
> RendererAccessibility in a follow-up CL. So could I postpone this work to that
> CL?

OK.

[dmazzoni, 2014-10-20 16:44:18]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org, jam@chromium.org

[dmazzoni, 2014-10-20 16:44:18]

+jam for content/
+aboxhall as FYI / additional review

[jam, 2014-10-20 20:19:14]

On 2014/10/20 16:44:18, dmazzoni wrote:
> +jam for content/
please use another owner, i'm overloaded
> +aboxhall as FYI / additional review

[dmazzoni, 2014-10-20 21:29:17]

dmazzoni@chromium.org changed reviewers:
+ jochen@chromium.org
- jam@chromium.org

[dmazzoni, 2014-10-20 21:29:17]

+jochen for content/

[jochen (gone - plz use gerrit), 2014-10-21 12:38:45]

lgtm

[Sungmann Cho, 2014-10-21 12:41:27]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-10-21 12:42:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651593002/180001

[commit-bot: I haz the power, 2014-10-21 14:05:37]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2014-10-21 14:06:39]

Patchset 5 (id:??) landed as
https://crrev.com/cbaf69539f099899555220b092ba3a501634bab3
Cr-Commit-Position: refs/heads/master@{#300482}