Always use same browser_options instance. possible_browser may have a state version because of the …

Always use same browser_options instance. possible_browser may have a stale version because of the cache decorator on browser_finder.FindBrowser.

BUG=428157
Committed: https://crrev.com/a5e666874f010b10c65060d27d72439c7cb2a67d
Cr-Commit-Position: refs/heads/master@{#301997}

[slamm, 2014-10-29 23:16:58]

slamm@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2014-10-29 23:20:10]

lgtm

https://codereview.chromium.org/688163003/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (left):

https://codereview.chromium.org/688163003/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:334: browser_options =
possible_browser.finder_options.browser_options
Are there other places where possible_browser's finder_options are accessed?
Also, given that this just made things flaky, it seems like it is begging for a
unittest. Would you mind adding one in a subsequent patch?

[slamm, 2014-10-29 23:22:42]

The CQ bit was checked by slamm@chromium.org

[slamm, 2014-10-29 23:22:44]

The CQ bit was unchecked by slamm@chromium.org

[slamm, 2014-10-29 23:22:55]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-10-29 23:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688163003/1

[slamm, 2014-10-29 23:36:11]

On 2014/10/29 23:20:10, tonyg wrote:
> lgtm
> 
>
https://codereview.chromium.org/688163003/diff/1/tools/telemetry/telemetry/pa...
> File tools/telemetry/telemetry/page/page_runner.py (left):
> 
>
https://codereview.chromium.org/688163003/diff/1/tools/telemetry/telemetry/pa...
> tools/telemetry/telemetry/page/page_runner.py:334: browser_options =
> possible_browser.finder_options.browser_options
> Are there other places where possible_browser's finder_options are accessed?
> Also, given that this just made things flaky, it seems like it is begging for
a
> unittest. Would you mind adding one in a subsequent patch?

I did not find any other cases of possible_browser.finder_options. Perhaps we
can remove that.
I am unsure what I would unittest. However, I would like to see if we can
improve the design.

[commit-bot: I haz the power, 2014-10-30 00:46:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-30 00:47:27]

Patchset 1 (id:??) landed as
https://crrev.com/a5e666874f010b10c65060d27d72439c7cb2a67d
Cr-Commit-Position: refs/heads/master@{#301997}