tools/telemetry/telemetry/page/page_runner.py - Issue 688163003: Always use same browser_options instance. possible_browser may have a state version because of the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 688163003: Always use same browser_options instance. possible_browser may have a state version because of the … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index f9d20ed9d15ff1468537a98e78913f929b876611..bc49abcc765f4c76e58c5c43cc13e01a9438e73f 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -331,7 +331,7 @@ def Run(test, page_set, expectations, finder_options, results):

'\n'.join(browser_finder.GetAllAvailableBrowserTypes(finder_options)))

sys.exit(-1)

- browser_options = possible_browser.finder_options.browser_options

tonyg 2014/10/29 23:20:10 Are there other places where possible_browser's fi

+ browser_options = finder_options.browser_options

browser_options.browser_type = possible_browser.browser_type

test.CustomizeBrowserOptions(browser_options)

« no previous file with comments | « no previous file | no next file » | no next file with comments »