Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 687823002: Don't package OSX's magic ._foo files (Closed)

Created:
6 years, 1 month ago by Sam Clegg
Modified:
6 years, 1 month ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Visibility:
Public.

Description

Don't package OSX's magic ._foo files These files are created by the OS when filesystems that don't support certain metadata features are used on OSX. Without this fix packages that do a recusive installation can end up containing such files. BUG= https://code.google.com/p/naclports/issues/detail?id=158 R=bradnelson@google.com Committed: https://chromium.googlesource.com/external/naclports/+/9ae02e34991e330c18fb9f6088597ff85931d84a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build_tools/common.sh View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Sam Clegg
6 years, 1 month ago (2014-10-28 21:53:25 UTC) #2
bradn
lgtm
6 years, 1 month ago (2014-10-28 22:04:57 UTC) #4
Sam Clegg
6 years, 1 month ago (2014-10-28 22:13:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ae02e34991e330c18fb9f6088597ff85931d84a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698