Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 6878038: [Sync] Ensure we don't hold a transaction when we access password store. (Closed)

Created:
8 years, 5 months ago by Nicolas Zea
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Raghu Simha, PaweĊ‚ Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

[Sync] Ensure we don't hold a transaction when we access password store. BUG=70658 TEST=ProfileSyncSerivcePasswordTest.EnsureNoTransactions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82174

Patch Set 1 #

Patch Set 2 : Rearrange #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -77 lines) Patch
M chrome/browser/sync/glue/password_change_processor.h View 4 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 4 chunks +19 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 2 chunks +70 lines, -62 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 3 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nicolas Zea
I think this ought to do it! Looking in autofill model associator, we use the ...
8 years, 5 months ago (2011-04-19 06:16:57 UTC) #1
ncarter (slow)
Drive-by observation; no need to wait for my LGTM. I see that you're using three ...
8 years, 5 months ago (2011-04-19 06:25:31 UTC) #2
ncarter (slow)
Drive-by observation; no need to wait for my LGTM. I see that you're using three ...
8 years, 5 months ago (2011-04-19 06:25:31 UTC) #3
Nicolas Zea
For every applychanges (where the queues get filled), there is one commitchanges. It's possible for ...
8 years, 5 months ago (2011-04-19 17:49:06 UTC) #4
Nicolas Zea
+mdm I think this could resolve the issues w.r.t. deadlocks when the password store has ...
8 years, 5 months ago (2011-04-19 19:12:00 UTC) #5
Mike Mammarella
8 years, 5 months ago (2011-04-19 21:09:02 UTC) #6
On 2011/04/19 19:12:00, nzea wrote:
> +mdm I think this could resolve the issues w.r.t. deadlocks when the password
> store has to interact with the UI thread.

Nice! This looks like it will probably do the trick. I'm not quite sure why I
was thinking that it wouldn't, in email. Threading is tricky so maybe I was
seeing something that wasn't a problem... but in any event this LGTM. Thanks so
much for taking the time to work on it!

Powered by Google App Engine
This is Rietveld 408576698