Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: extensions/common/api/cast_channel/logging.proto

Issue 687733004: Implement crypto signature verification routines using OpenSSL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed code review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/cast_channel/logger_unittest.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/cast_channel/logging.proto
diff --git a/extensions/common/api/cast_channel/logging.proto b/extensions/common/api/cast_channel/logging.proto
index 58d86ac68aa4bec471bb8f0d0b73e81f8798b166..94b2d8afb0405c7caa63a5894306d5e465e73fa1 100644
--- a/extensions/common/api/cast_channel/logging.proto
+++ b/extensions/common/api/cast_channel/logging.proto
@@ -101,10 +101,15 @@ enum ChallengeReplyErrorType {
CHALLENGE_REPLY_ERROR_MESSAGE_ERROR = 6;
CHALLENGE_REPLY_ERROR_NO_RESPONSE = 7;
CHALLENGE_REPLY_ERROR_FINGERPRINT_NOT_FOUND = 8;
- CHALLENGE_REPLY_ERROR_NSS_CERT_PARSING_FAILED = 9;
- CHALLENGE_REPLY_ERROR_NSS_CERT_NOT_SIGNED_BY_TRUSTED_CA = 10;
- CHALLENGE_REPLY_ERROR_NSS_CANNOT_EXTRACT_PUBLIC_KEY = 11;
- CHALLENGE_REPLY_ERROR_NSS_SIGNED_BLOBS_MISMATCH = 12;
+ CHALLENGE_REPLY_ERROR_CERT_PARSING_FAILED = 9;
+ CHALLENGE_REPLY_ERROR_CERT_NOT_SIGNED_BY_TRUSTED_CA = 10;
+ CHALLENGE_REPLY_ERROR_CANNOT_EXTRACT_PUBLIC_KEY = 11;
+ CHALLENGE_REPLY_ERROR_SIGNED_BLOBS_MISMATCH = 12;
+}
+
+message OpenSSLError {
+ optional string filename = 1;
+ optional int32 line = 2;
davidben 2014/11/01 00:19:35 Does this send the Chrome version? These aren't go
Kevin M 2014/11/03 18:31:46 The Chrome version is included in the feedback rep
}
message SocketEvent {
@@ -126,6 +131,8 @@ message SocketEvent {
optional ChallengeReplyErrorType challenge_reply_error_type = 11;
optional int32 nss_error_code = 12;
+
+ repeated OpenSSLError openssl_error = 13;
davidben 2014/11/01 00:19:35 This should have a comment that this is specifical
Kevin M 2014/11/03 18:31:46 Done.
}
message AggregatedSocketEvent {
« no previous file with comments | « extensions/browser/api/cast_channel/logger_unittest.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698