Implement crypto signature verification routines using OpenSSL.

extensions/common/api/cast_channel/logging.proto

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package extensions.core_api.cast_channel.proto;
 
@@ skipping 83 matching lines @@
 
 enum ChallengeReplyErrorType {
   CHALLENGE_REPLY_ERROR_NONE = 1;
   CHALLENGE_REPLY_ERROR_PEER_CERT_EMPTY = 2;
   CHALLENGE_REPLY_ERROR_WRONG_PAYLOAD_TYPE = 3;
   CHALLENGE_REPLY_ERROR_NO_PAYLOAD = 4;
   CHALLENGE_REPLY_ERROR_PAYLOAD_PARSING_FAILED = 5;
   CHALLENGE_REPLY_ERROR_MESSAGE_ERROR = 6;
   CHALLENGE_REPLY_ERROR_NO_RESPONSE = 7;
   CHALLENGE_REPLY_ERROR_FINGERPRINT_NOT_FOUND = 8;
-  CHALLENGE_REPLY_ERROR_NSS_CERT_PARSING_FAILED = 9;
-  CHALLENGE_REPLY_ERROR_NSS_CERT_NOT_SIGNED_BY_TRUSTED_CA = 10;
-  CHALLENGE_REPLY_ERROR_NSS_CANNOT_EXTRACT_PUBLIC_KEY = 11;
-  CHALLENGE_REPLY_ERROR_NSS_SIGNED_BLOBS_MISMATCH = 12;
+  CHALLENGE_REPLY_ERROR_CERT_PARSING_FAILED = 9;
+  CHALLENGE_REPLY_ERROR_CERT_NOT_SIGNED_BY_TRUSTED_CA = 10;
+  CHALLENGE_REPLY_ERROR_CANNOT_EXTRACT_PUBLIC_KEY = 11;
+  CHALLENGE_REPLY_ERROR_SIGNED_BLOBS_MISMATCH = 12;
+}
+
+message OpenSSLError {
+  optional string filename = 1;
+  optional int32 line = 2;

[davidben, 2014/11/01 00:19:35]

Does this send the Chrome version? These aren't going to be meaningful without
it either.

[Kevin M, 2014/11/03 18:31:46]

The Chrome version is included in the feedback report metadata.

FYI, the error-reporting changes have been moved to a separate Git branch, which
I'll put out for review once I land this CL.

 }
 
 message SocketEvent {
   // Required
   optional EventType type = 1;
   optional int64 timestamp_micros = 2;
 
   optional string details = 3;
 
   optional int32 net_return_value = 4;
 
   optional string message_namespace = 5;
 
   optional ReadyState ready_state = 6;
   optional ConnectionState connection_state = 7;
   optional ReadState read_state = 8;
   optional WriteState write_state = 9;
   optional ErrorState error_state = 10;
 
   optional ChallengeReplyErrorType challenge_reply_error_type = 11;
   optional int32 nss_error_code = 12;
+
+  repeated OpenSSLError openssl_error = 13;

[davidben, 2014/11/01 00:19:35]

This should have a comment that this is specifically for manual debugging and no
code should ever programmatically do anything with these values. Constraining
BoringSSL to file names and line numbers of errors would be even worse than
constraining the reason codes.

(To be clear, neither of them are guaranteed to be stable across versions, so
that comment would be true for both.)

[Kevin M, 2014/11/03 18:31:46]

Done.

 }
 
 message AggregatedSocketEvent {
   optional int32 id = 1;
   optional int32 endpoint_id = 2;
   optional ChannelAuth channel_auth_type = 3;
   repeated SocketEvent socket_event = 4;
   optional int64 bytes_read = 5;
   optional int64 bytes_written = 6;
 }
 
 message Log {
   // Each AggregatedSocketEvent represents events recorded for a socket.
   repeated AggregatedSocketEvent aggregated_socket_event = 1;
 
   // Number of socket log entries evicted by the logger due to size constraints.
   optional int32 num_evicted_aggregated_socket_events = 2;
 
   // Number of event log entries evicted by the logger due to size constraints.
   optional int32 num_evicted_socket_events = 3;
 }