Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 687733003: Change configs/try.py to get the list of config files to use from args. (Closed)

Created:
6 years, 1 month ago by qyearsley
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change configs/try.py to get the list of config files to use from args. For example, after uploading this CL, I just ran: ./try.py mac.bisect.blink_perf.cfg linux.perf_test.tab_switching.cfg. I expect it should only start two try jobs. If you run ./try.py (with no arguments), it prints usage help and a "too few arguments" message. BUG=415890 Committed: https://crrev.com/aac2930feadd3552151930baa0df2e77782c6f58 Cr-Commit-Position: refs/heads/master@{#302414}

Patch Set 1 #

Patch Set 2 : Replaced --svn_url with -S in git try invocation. #

Total comments: 1

Patch Set 3 : Fix problems introduced by recent commits. #

Patch Set 4 : Run git try separately for each bot; add a logging statement; change results error output. #

Patch Set 5 : Correct "linux_perf_bot" -> "linux_perf_bisect". #

Patch Set 6 : Change RemoveBuildFiles to use exception instead of return code, to get more specific error message #

Patch Set 7 : In RemoveBuildFiles, remove a file if there's a file instead of dir. #

Patch Set 8 : Add android_gn_perf_bisect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -74 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 1 2 3 4 5 6 7 12 chunks +39 lines, -37 lines 0 comments Download
M tools/auto_bisect/configs/android.bisect.blink_perf.cfg View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/auto_bisect/configs/linux.bisect.page_cycler.cfg View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/auto_bisect/configs/mac.bisect.blink_perf.cfg View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/auto_bisect/configs/try.py View 1 2 3 4 5 6 7 7 chunks +19 lines, -25 lines 0 comments Download
M tools/auto_bisect/configs/win.bisect.blink_perf.cfg View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M tools/run-bisect-perf-regression.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
qyearsley
6 years, 1 month ago (2014-10-28 19:43:26 UTC) #2
qyearsley
On 2014/10/28 19:43:26, qyearsley wrote: Note, currently configs/try.py is still broken -- I never meant ...
6 years, 1 month ago (2014-10-28 19:44:16 UTC) #3
Sergiy Byelozyorov
lgtm with comments... but please make sure this works before commiting https://codereview.chromium.org/687733003/diff/20001/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): ...
6 years, 1 month ago (2014-10-30 11:49:13 UTC) #4
qyearsley
On 2014/10/30 11:49:13, Sergiy Byelozyorov wrote: > lgtm with comments... but please make sure this ...
6 years, 1 month ago (2014-11-02 16:33:00 UTC) #5
qyearsley
On 2014/11/02 16:33:00, qyearsley wrote: > On 2014/10/30 11:49:13, Sergiy Byelozyorov wrote: > > lgtm ...
6 years, 1 month ago (2014-11-03 05:30:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687733003/140001
6 years, 1 month ago (2014-11-03 05:31:43 UTC) #8
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years, 1 month ago (2014-11-03 06:12:01 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 06:12:52 UTC) #10
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/aac2930feadd3552151930baa0df2e77782c6f58
Cr-Commit-Position: refs/heads/master@{#302414}

Powered by Google App Engine
This is Rietveld 408576698