Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 687733003: Change configs/try.py to get the list of config files to use from args. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add android_gn_perf_bisect Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/configs/win.bisect.blink_perf.cfg ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index 344e36b1691b1aa0e2da68852bcd022c5783a0ea..815d9574b2ef3037858f8ac73401ed42681c5726 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -248,12 +248,12 @@ def _RunPerformanceTest(config):
bisect_utils.OutputAnnotationStepStart('Building With Patch')
opts = _CreateBisectOptionsFromConfig(config)
- b = bisect_perf_regression.BisectPerformanceMetrics(opts)
+ b = bisect_perf_regression.BisectPerformanceMetrics(opts, os.getcwd())
if bisect_utils.RunGClient(['runhooks']):
raise RuntimeError('Failed to run gclient runhooks')
- if not b.BuildCurrentRevision('chromium'):
+ if not b.ObtainBuild('chromium'):
raise RuntimeError('Patched version failed to build.')
bisect_utils.OutputAnnotationStepClosed()
@@ -282,7 +282,7 @@ def _RunPerformanceTest(config):
if bisect_utils.RunGClient(['runhooks']):
raise RuntimeError('Failed to run gclient runhooks')
- if not b.BuildCurrentRevision('chromium'):
+ if not b.ObtainBuild('chromium'):
raise RuntimeError('Unpatched version failed to build.')
bisect_utils.OutputAnnotationStepClosed()
« no previous file with comments | « tools/auto_bisect/configs/win.bisect.blink_perf.cfg ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698