Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 687583003: Mark 99 tests as NeedsManualRebaseline for SK_IGNORE_PROPER_FRACTIONAL_SCALING. (Closed)

Created:
6 years, 1 month ago by jbroman
Modified:
6 years, 1 month ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Mark 99 tests as NeedsManualRebaseline for SK_IGNORE_PROPER_FRACTIONAL_SCALING. These tests exhibit minor differences as a result of a change in Skia's scaling. They will be rebaselined (via NeedsRebaseline) once the Chromium-side change to flip this flag lands: https://codereview.chromium.org/686853003 The reference test css3/masking/mask-repeat-space-padding.html has been changed to a pixel test since, though they both appear visually identical, there are miniscule differences as a result of this change. BUG=391051 TBR=schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -51 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +102 lines, -0 lines 0 comments Download
D LayoutTests/css3/masking/mask-repeat-space-padding-expected.html View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
Here are the 99 layout tests that are affected, and the diff (Mac used here, ...
6 years, 1 month ago (2014-10-28 21:24:50 UTC) #2
jbroman
Landing TBR as suggested by schenney: https://codereview.chromium.org/686853003/ (once win_blink_rel agrees)
6 years, 1 month ago (2014-10-28 22:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687583003/1
6 years, 1 month ago (2014-10-28 22:20:37 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 22:24:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184548

Powered by Google App Engine
This is Rietveld 408576698