Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 686853003: Remove SK_IGNORE_PROPER_FRACTIONAL_SCALING. (Closed)

Created:
6 years, 1 month ago by jbroman
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove SK_IGNORE_PROPER_FRACTIONAL_SCALING. This causes Skia to use fractional bitmap scaling in Chromium, which is necessary to avoid both record-time scaling and "seam" artifacts in bitmap patterns. Necessary suppressions in Blink layout tests are in this CL: https://codereview.chromium.org/687583003 BUG=391051 Committed: https://crrev.com/364f048a2798c8ca561d9c342cadee9018a6d153 Cr-Commit-Position: refs/heads/master@{#301839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Stephen Chennney
LGTM. You can also land expectations changes like this TBR, but regardless you should watch ...
6 years, 1 month ago (2014-10-28 21:31:36 UTC) #2
jbroman
Err, this is the Chromium-side config change. I need to land the Blink-side TestExpectations change ...
6 years, 1 month ago (2014-10-28 21:36:03 UTC) #3
jbroman
TBRed the TestExpectations change as suggested. It will roll into Chromium shortly. +reed,fmalita for src/skia ...
6 years, 1 month ago (2014-10-28 23:07:05 UTC) #5
f(malita)
On 2014/10/28 23:07:05, jbroman wrote: > TBRed the TestExpectations change as suggested. It will roll ...
6 years, 1 month ago (2014-10-28 23:57:54 UTC) #6
reed1
this flag existed only for chrome, so glad to have it removed. humper, you should ...
6 years, 1 month ago (2014-10-29 13:53:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686853003/1
6 years, 1 month ago (2014-10-29 14:05:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 15:27:32 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 15:28:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/364f048a2798c8ca561d9c342cadee9018a6d153
Cr-Commit-Position: refs/heads/master@{#301839}

Powered by Google App Engine
This is Rietveld 408576698