Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 687563004: Change parameter type on AudioDeviceThread::Callback::Process() (Closed)

Created:
6 years, 1 month ago by jrummell
Modified:
6 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change parameter type on AudioDeviceThread::Callback::Process() Parameter type is now uint32 to avoid saturation issues that may happen when converting to int. BUG=none TEST=media_unittests pass Committed: https://crrev.com/42f4aae371cbed6c8e3c8901c26ebf54e8fa9835 Cr-Commit-Position: refs/heads/master@{#301757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M media/audio/audio_device_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_device_thread.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M media/audio/audio_input_device.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_device.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jrummell
PTAL. This is removing a TODO(acolwell).
6 years, 1 month ago (2014-10-28 23:48:12 UTC) #2
DaleCurtis
lgtm
6 years, 1 month ago (2014-10-28 23:53:02 UTC) #3
scherkus (not reviewing)
lgtm thanks for cleaning this up!
6 years, 1 month ago (2014-10-28 23:55:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687563004/1
6 years, 1 month ago (2014-10-29 00:23:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 01:13:09 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 01:13:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42f4aae371cbed6c8e3c8901c26ebf54e8fa9835
Cr-Commit-Position: refs/heads/master@{#301757}

Powered by Google App Engine
This is Rietveld 408576698