Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: media/audio/audio_device_thread.cc

Issue 687563004: Change parameter type on AudioDeviceThread::Callback::Process() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_device_thread.h ('k') | media/audio/audio_input_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_device_thread.cc
diff --git a/media/audio/audio_device_thread.cc b/media/audio/audio_device_thread.cc
index 46d6d863250a4e5e0a521e5d88b858b11d500799..24ba5096eb4b10e6b99b888c729863ce0494b1df 100644
--- a/media/audio/audio_device_thread.cc
+++ b/media/audio/audio_device_thread.cc
@@ -172,14 +172,8 @@ void AudioDeviceThread::Thread::Run() {
{
base::AutoLock auto_lock(callback_lock_);
- if (callback_) {
- // TODO(acolwell): Update downstream code to use a uint32.
- // Under normal operation saturation should never occur here
- // and even if it does, it would only cause a temporary loss
- // of A/V sync which is much better than crashing or halting
- // playback.
- callback_->Process(base::saturated_cast<int>(pending_data));
- }
+ if (callback_)
+ callback_->Process(pending_data);
}
// Let the other end know which buffer we just filled. The buffer index is
« no previous file with comments | « media/audio/audio_device_thread.h ('k') | media/audio/audio_input_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698