Issue 687453006: Add a few missing overrides found by a new clang warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687453006: Add a few missing overrides found by a new clang warning. (Closed)

Created:
6 years, 1 month ago by Nico

Modified:
6 years, 1 month ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add a few missing overrides found by a new clang warning. Namely, -Winconsistent-missing-override. No behavior change. BUG=428099 Committed: https://crrev.com/be4d58827b192b80e962f873891d69f4c6506eb4 Cr-Commit-Position: refs/heads/master@{#302132}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -55 lines)			Patch
	M	win8/metro_driver/ime/text_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	win8/metro_driver/metro_driver_win7.cc	View		12 chunks	+54 lines, -54 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687453006/1

6 years, 1 month ago (2014-10-30 18:03:21 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-30 19:31:19 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/be4d58827b192b80e962f873891d69f4c6506eb4
Cr-Commit-Position: refs/heads/master@{#302132}