win8/metro_driver/ime/text_service.cc - Issue 687453006: Add a few missing overrides found by a new clang warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/metro_driver/ime/text_service.cc

Issue 687453006: Add a few missing overrides found by a new clang warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/metro_driver/ime/text_service.cc

diff --git a/win8/metro_driver/ime/text_service.cc b/win8/metro_driver/ime/text_service.cc

index cb9421a7336c15b239e4c26db9ed0ffd20ee8381..11356199339424f0cee5fa84c9e063276fe65c5f 100644

--- a/win8/metro_driver/ime/text_service.cc

+++ b/win8/metro_driver/ime/text_service.cc

@@ -392,7 +392,7 @@ class TextServiceImpl : public TextService,

delegate_->OnTextCommitted(text);

}

- virtual RECT GetCaretBounds() {

+ virtual RECT GetCaretBounds() override {

if (composition_character_bounds_.empty()) {

const RECT rect = {};

return rect;

« no previous file with comments | « no previous file | win8/metro_driver/metro_driver_win7.cc » ('j') | no next file with comments »