Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 687203002: Add new video metrics from webrtc to histograms.xml. (Closed)

Created:
6 years, 1 month ago by asapersson2
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add new video metrics from webrtc to histograms.xml. - number of sent/received RTCP NACK/FIR/PLI per minute - percentage of unique sent/received NACK requests - percentage of discarded/duplicated packets by the jitter buffer - permille of sent/received key frames CL where stats will be added: https://webrtc-codereview.appspot.com/24959004/ BUG=419657 Committed: https://crrev.com/f3684a08bda8522afff4267fdfc2ceb8705e9980 Cr-Commit-Position: refs/heads/master@{#302601}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
asapersson2
Please take a look.
6 years, 1 month ago (2014-10-30 11:13:54 UTC) #5
mflodman_chromium_OOO
LGTM, but it would be good create a crbug track WebRTC video stats we're about ...
6 years, 1 month ago (2014-10-31 08:00:02 UTC) #6
asapersson2
On 2014/10/31 08:00:02, mflodman wrote: > LGTM, but it would be good create a crbug ...
6 years, 1 month ago (2014-10-31 08:21:48 UTC) #7
Alexei Svitkine (slow)
https://codereview.chromium.org/687203002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/687203002/diff/40001/tools/metrics/histograms/histograms.xml#newcode39116 tools/metrics/histograms/histograms.xml:39116: + <summary>The number of received RTCP FIR packets per ...
6 years, 1 month ago (2014-10-31 16:55:25 UTC) #8
asapersson2
https://codereview.chromium.org/687203002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/687203002/diff/40001/tools/metrics/histograms/histograms.xml#newcode39116 tools/metrics/histograms/histograms.xml:39116: + <summary>The number of received RTCP FIR packets per ...
6 years, 1 month ago (2014-11-03 10:01:04 UTC) #9
Alexei Svitkine (slow)
lgtm
6 years, 1 month ago (2014-11-03 15:15:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687203002/80001
6 years, 1 month ago (2014-11-04 09:46:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 1 month ago (2014-11-04 11:51:21 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 11:51:57 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f3684a08bda8522afff4267fdfc2ceb8705e9980
Cr-Commit-Position: refs/heads/master@{#302601}

Powered by Google App Engine
This is Rietveld 408576698