tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6a4ad97286e1f0b2b03b1fbbe8d3f3843383b9b8..c41fc85f5072c9aa3bfe5bfba21b98019db85516 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -39097,6 +39097,72 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="WebRTC.Video.DiscardedPacketsInPercent" units="%">
+  <owner>asapersson@chromium.org</owner>
+  <summary>
+    Percentage of discarded packets by the jitter buffer due to arriving too
+    late.
+  </summary>
+</histogram>
+
+<histogram name="WebRTC.Video.DuplicatedPacketsInPercent" units="%">
+  <owner>asapersson@chromium.org</owner>
+  <summary>Percentage of duplicated packets in the jitter buffer.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.FirPacketsReceivedPerMinute"
+    units="packets/minute">
+  <owner>asapersson@chromium.org</owner>
+  <summary>The number of received RTCP FIR packets per minute.</summary>

[Alexei Svitkine (slow), 2014/10/31 16:55:24]

When is this recorded? Every minute? Only when a video is playing?

[asapersson2, 2014/11/03 10:01:04]

Done.

+</histogram>
+
+<histogram name="WebRTC.Video.FirPacketsSentPerMinute" units="packets/minute">
+  <owner>asapersson@chromium.org</owner>
+  <summary>The number of sent RTCP FIR packets per minute.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.KeyFramesReceivedInPermille" units="permille">
+  <owner>asapersson@chromium.org</owner>
+  <summary>Permille of received frames that are key frames.</summary>

[Alexei Svitkine (slow), 2014/10/31 16:55:24]

Again when is this recorded? At the end of session? Multiple times during a
session, so you get double counting? Please make all of these descriptions more
precise so it's clearer what and how they are measuring things.

[asapersson2, 2014/11/03 10:01:04]

Updated comments and added when metrics are recorded.

+</histogram>
+
+<histogram name="WebRTC.Video.KeyFramesSentInPermille" units="permille">
+  <owner>asapersson@chromium.org</owner>
+  <summary>Permille of sent frames that are key frames.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.NackPacketsReceivedPerMinute"
+    units="packets/minute">
+  <owner>asapersson@chromium.org</owner>
+  <summary>The number of received RTCP NACK packets per minute.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.NackPacketsSentPerMinute" units="packets/minute">
+  <owner>asapersson@chromium.org</owner>
+  <summary>The number of sent RTCP NACK packets per minute.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.PliPacketsReceivedPerMinute"
+    units="packets/minute">
+  <owner>asapersson@chromium.org</owner>
+  <summary>The number of received RTCP PLI packets per minute.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.PliPacketsSentPerMinute" units="packets/minute">
+  <owner>asapersson@chromium.org</owner>
+  <summary>The number of sent RTCP PLI packets per minute.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.UniqueNackRequestsReceivedInPercent" units="%">
+  <owner>asapersson@chromium.org</owner>
+  <summary>Percentage of received NACKed RTP packets that are unique.</summary>
+</histogram>
+
+<histogram name="WebRTC.Video.UniqueNackRequestsSentInPercent" units="%">
+  <owner>asapersson@chromium.org</owner>
+  <summary>Percentage of sent NACKed RTP packets that are unique.</summary>

[Alexei Svitkine (slow), 2014/10/31 16:55:24]

When is this recorded? Please document.

[asapersson2, 2014/11/03 10:01:04]

Done.

+</histogram>
+
 <histogram name="WebRTC.webkitApiCount" enum="JavaScriptAPIName">
   <owner>perkj@chromium.org</owner>
   <summary>Counts number of calls to WebRTC APIs from JavaScript.</summary>