Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 687143004: Remove workaround for opening a new tab. (Closed)

Created:
6 years, 1 month ago by achuithb
Modified:
6 years, 1 month ago
Reviewers:
tbarzic
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove workaround for opening a new tab. This workaround should no longer be necessary, and looks like the first tab is created elsewhere. BUG=374462 TEST=run_tests Committed: https://crrev.com/f96252bbb41bd3b1b7db556a34499761b2519c8e Cr-Commit-Position: refs/heads/master@{#301957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
achuithb
Please review, Toni
6 years, 1 month ago (2014-10-29 20:17:35 UTC) #2
tbarzic
lgtm
6 years, 1 month ago (2014-10-29 20:24:42 UTC) #3
achuithb
On 2014/10/29 20:24:42, tbarzic wrote: > lgtm ty
6 years, 1 month ago (2014-10-29 20:44:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687143004/1
6 years, 1 month ago (2014-10-29 20:46:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687143004/1
6 years, 1 month ago (2014-10-29 21:51:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:49:19 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 22:50:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f96252bbb41bd3b1b7db556a34499761b2519c8e
Cr-Commit-Position: refs/heads/master@{#301957}

Powered by Google App Engine
This is Rietveld 408576698