Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 687143004: Remove workaround for opening a new tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
index 4ff1d700ab6f56fd890ff28096656634ec193c10..6cfe0a3ea0808e02452012a669e55c4a0087121f 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py
@@ -236,21 +236,3 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
# Wait for extensions to load.
self._WaitForBrowserToComeUp()
-
- # Workaround for crbug.com/374462 - the bug doesn't manifest in the guest
- # session, which also starts with an open browser tab.
- retries = 3
- while not self._is_guest and not self.browser_options.gaia_login:
- try:
- # Open a new window/tab.
- tab = self.tab_list_backend.New(timeout=30)
- tab.Navigate('about:blank', timeout=10)
- break
- except (exceptions.TabCrashException, util.TimeoutException,
- IndexError):
- retries -= 1
- logging.warning('TabCrashException/TimeoutException in '
- 'new tab creation/navigation, '
- 'remaining retries %d', retries)
- if not retries:
- raise
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698