Issue 68713006: Enable notification collapse-expand under a flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68713006: Enable notification collapse-expand under a flag. (Closed)

Created:
7 years, 1 month ago by dewittj

Modified:
7 years, 1 month ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable notification collapse-expand under a flag. This fixes a layout bug that was dormant since previously notifications were always expanded. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235651

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -15 lines)			Patch
M	ui/message_center/message_center_style.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/message_center/views/message_center_view.cc	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	ui/message_center/views/message_popup_collection.cc	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	ui/message_center/views/notification_view.cc	View	1	4 chunks	+16 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

lgtm https://codereview.chromium.org/68713006/diff/1/ui/message_center/views/notification_view.cc File ui/message_center/views/notification_view.cc (right): https://codereview.chromium.org/68713006/diff/1/ui/message_center/views/notification_view.cc#newcode796 ui/message_center/views/notification_view.cc:796: return std::max(message_line_limit, 0); can it be DCHECK(limit > ...

7 years, 1 month ago (2013-11-15 19:19:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/68713006/60001

7 years, 1 month ago (2013-11-15 22:11:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/68713006/60001

7 years, 1 month ago (2013-11-16 00:42:48 UTC) #4

Message was sent while issue was closed.

Change committed as 235651

Expand Messages | Collapse Messages