Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: ui/message_center/views/notification_view.cc

Issue 68713006: Enable notification collapse-expand under a flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address nit. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/message_popup_collection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/notification_view.cc
diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc
index 82223390b36a3a856604fe067c81209c0cdef300..8abc2e3c007431dc241704bb736d17eafb1df824 100644
--- a/ui/message_center/views/notification_view.cc
+++ b/ui/message_center/views/notification_view.cc
@@ -485,7 +485,9 @@ NotificationView::NotificationView(const Notification& notification,
gfx::TruncateString(notification.title(), kTitleCharacterLimit),
font_list);
title_view_->SetLineHeight(kTitleLineHeight);
- title_view_->SetLineLimit(message_center::kTitleLineLimit);
+ title_view_->SetLineLimit(IsExperimentalNotificationUIEnabled() ?
+ message_center::kExperimentalTitleLineLimit :
+ message_center::kTitleLineLimit);
title_view_->SetColors(message_center::kRegularTextColor,
kRegularTextBackgroundColor);
title_view_->set_border(MakeTextBorder(padding, 3, 0));
@@ -623,7 +625,6 @@ int NotificationView::GetHeightForWidth(int width) {
int content_width = width - GetInsets().width();
int top_height = top_view_->GetHeightForWidth(content_width);
int bottom_height = bottom_view_->GetHeightForWidth(content_width);
- int content_height = std::max(top_height, kIconSize) + bottom_height;
// <http://crbug.com/230448> Fix: Adjust the height when the message_view's
// line limit would be different for the specified width than it currently is.
@@ -632,11 +633,13 @@ int NotificationView::GetHeightForWidth(int width) {
int used_limit = message_view_->GetLineLimit();
int correct_limit = GetMessageLineLimit(width);
if (used_limit != correct_limit) {
- content_height -= GetMessageHeight(content_width, used_limit);
- content_height += GetMessageHeight(content_width, correct_limit);
+ top_height -= GetMessageHeight(content_width, used_limit);
+ top_height += GetMessageHeight(content_width, correct_limit);
}
}
+ int content_height = std::max(top_height, kIconSize) + bottom_height;
+
// Adjust the height to make sure there is at least 16px of space below the
// icon if there is any space there (<http://crbug.com/232966>).
if (content_height > kIconSize)
@@ -781,14 +784,17 @@ int NotificationView::GetMessageLineLimit(int width) {
if (is_expanded() && !image_view_)
return message_center::kMessageExpandedLineLimit;
- // If there's a title ensure title + message lines <= collapsed line limit.
- if (title_view_) {
- int title_lines = title_view_->GetLinesForWidthAndLimit(width, -1);
- return std::max(message_center::kMessageCollapsedLineLimit - title_lines,
- 0);
+ int message_line_limit = message_center::kMessageCollapsedLineLimit;
+
+ // Subtract any lines taken by the context message.
+ if (context_message_view_) {
+ message_line_limit -= context_message_view_->GetLinesForWidthAndLimit(
+ width,
+ message_center::kContextMessageLineLimit);
}
- return message_center::kMessageCollapsedLineLimit;
+ DCHECK_GT(message_line_limit, 0);
+ return message_line_limit;
}
int NotificationView::GetMessageLines(int width, int limit) {
« no previous file with comments | « ui/message_center/views/message_popup_collection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698