Issue 687073003: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687073003: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates. (Closed)

Created:
6 years, 1 month ago by Joao da Silva

Modified:
6 years, 1 month ago

Reviewers:

CC:
grit-developer_googlegroups.com

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Set the MAXLEN/maxLength attribute for strings in ADM[X] templates. This allows strings and JSON blobs in the registry and GPO objects to have a length longer than the default of 1023 characters. BUG=chromium:428340 Committed: https://code.google.com/p/grit-i18n/source/detail?r=182

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	grit/format/policy_templates/writers/adm_writer.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer_unittest.py	View	5 chunks	+5 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer_unittest.py	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	grit/format/policy_templates/writers/xml_formatted_writer.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Original review at https://codereview.chromium.org/692033002/

6 years, 1 month ago (2014-11-05 11:12:13 UTC) #1

Joao da Silva

6 years, 1 month ago (2014-11-05 11:12:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r182 (presubmit successful).

Expand Messages | Collapse Messages