Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: grit/format/policy_templates/writers/adm_writer.py

Issue 687073003: Set the MAXLEN/maxLength attribute for strings in ADM[X] templates. (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | grit/format/policy_templates/writers/adm_writer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/format/policy_templates/writers/adm_writer.py
===================================================================
--- grit/format/policy_templates/writers/adm_writer.py (revision 181)
+++ grit/format/policy_templates/writers/adm_writer.py (working copy)
@@ -122,6 +122,10 @@
if policy['type'] == 'int':
# The default max for NUMERIC values is 9999 which is too small for us.
builder.AddLine('MIN 0 MAX 2000000000')
+ if policy['type'] in ('string', 'dict'):
+ # The default max for EDITTEXT values is 1023, which is too small for
+ # big JSON blobs and other string policies.
+ builder.AddLine('MAXLEN 1000000')
if policy['type'] in ('int-enum', 'string-enum'):
builder.AddLine('ITEMLIST', 1)
for item in policy['items']:
« no previous file with comments | « no previous file | grit/format/policy_templates/writers/adm_writer_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698