Turn off dump/emit routines when building minimal subzero.

Turn off dump/emit routines when building minimal subzero.

Remove the dump/emit routines when ALLOW_DUMP=0. Also fixes some
verbosity messages to not print if ALLOW_DUMP=0. Note: emit routines
needed for emitIAS are not turned off.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b6c96af1e5f019374ab93b2b66fbf79247d24660

[Karl, 2014-11-06 22:49:46]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2014-11-12 14:34:15]

Otherwise lgtm.

I still would prefer to get rid of the dump/emit functions entirely, not just
their bodies, but that can be an itch for another day.

https://codereview.chromium.org/686913005/diff/20001/src/IceTypes.cpp
File src/IceTypes.cpp (right):

https://codereview.chromium.org/686913005/diff/20001/src/IceTypes.cpp#newcode254
src/IceTypes.cpp:254: const char *typeString(Type Ty) {
Can you "get rid of" this as well?

https://codereview.chromium.org/686913005/diff/20001/src/llvm2ice.cpp
File src/llvm2ice.cpp (right):

https://codereview.chromium.org/686913005/diff/20001/src/llvm2ice.cpp#newcode243
src/llvm2ice.cpp:243: for (unsigned i = 0; i != VerboseList.size(); ++i)
Might be slightly cleaner to move the ALLOW_DUMP test here?  e.g.

for (unsigned i = 0; ALLOW_DUMP && i != VerboseList.size(); ++i)

[Karl, 2014-11-17 18:58:48]

Committed patchset #3 (id:40001) manually as
b6c96af1e5f019374ab93b2b66fbf79247d24660 (presubmit successful).

[Karl, 2014-11-17 18:59:46]

https://codereview.chromium.org/686913005/diff/20001/src/IceTypes.cpp
File src/IceTypes.cpp (right):

https://codereview.chromium.org/686913005/diff/20001/src/IceTypes.cpp#newcode254
src/IceTypes.cpp:254: const char *typeString(Type Ty) {
On 2014/11/12 14:34:15, stichnot wrote:
> Can you "get rid of" this as well?

At the moment, these names are used to generate labels for constants, and can't
be used. Not changing.

https://codereview.chromium.org/686913005/diff/20001/src/llvm2ice.cpp
File src/llvm2ice.cpp (right):

https://codereview.chromium.org/686913005/diff/20001/src/llvm2ice.cpp#newcode243
src/llvm2ice.cpp:243: for (unsigned i = 0; i != VerboseList.size(); ++i)
On 2014/11/12 14:34:15, stichnot wrote:
> Might be slightly cleaner to move the ALLOW_DUMP test here?  e.g.
> 
> for (unsigned i = 0; ALLOW_DUMP && i != VerboseList.size(); ++i)

Done.

[jvoung (off chromium), 2014-11-17 19:15:11]

https://codereview.chromium.org/686913005/diff/40001/tests_lit/reader_tests/a...
File tests_lit/reader_tests/alloca.ll (right):

https://codereview.chromium.org/686913005/diff/40001/tests_lit/reader_tests/a...
tests_lit/reader_tests/alloca.ll:3: ; REQUIRES: allow_dump
Sorry this is a bit late, but if the whole reader_tests directory requires
allow_dump, you might have been able to just create a lit.local.cfg file with:

features = set(config.root.available_features.split())
if not 'allow_dump' in features:
  config.unsupported = True

or something like that