Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: src/llvm2ice.cpp

Issue 686913005: Turn off dump/emit routines when building minimal subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/llvm2ice.cpp
diff --git a/src/llvm2ice.cpp b/src/llvm2ice.cpp
index 12c241a8b7a2c180fa1c759b41c2d83915ec406a..774a8e6a88dd8ebfd443c8ebcf75b6cc91ac5cc9 100644
--- a/src/llvm2ice.cpp
+++ b/src/llvm2ice.cpp
@@ -192,8 +192,7 @@ static int GetReturnValue(int Val) {
static struct {
const char *FlagName;
int FlagValue;
-} ConditionalBuildAttributes[] = {{"text_asm", ALLOW_TEXT_ASM},
- {"dump", ALLOW_DUMP},
+} ConditionalBuildAttributes[] = {{"dump", ALLOW_DUMP},
{"llvm_cl", ALLOW_LLVM_CL},
{"llvm_ir", ALLOW_LLVM_IR},
{"llvm_ir_as_input", ALLOW_LLVM_IR_AS_INPUT},
@@ -236,8 +235,12 @@ int main(int argc, char **argv) {
DisableTranslation = true;
Ice::VerboseMask VMask = Ice::IceV_None;
- for (unsigned i = 0; i != VerboseList.size(); ++i)
- VMask |= VerboseList[i];
+ // Don't generate verbose messages if routines
+ // to dump messages are not available.
+ if (ALLOW_DUMP) {
+ for (unsigned i = 0; i != VerboseList.size(); ++i)
+ VMask |= VerboseList[i];
+ }
std::ofstream Ofs;
if (OutputFilename != "-") {

Powered by Google App Engine
This is Rietveld 408576698